shell: rename shell_xxx_impl wrapper functions to shell_fprintf_xxx
#77192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
carlescufi,
jakub-uC,
jukkar,
pdgendt,
rlubos,
ssharks and
tbursztyka
Contributor
Author
|
👀 @jakub-uC just a ping to see if you might have a moment to review. |
jakub-uC
previously approved these changes
Aug 28, 2024
Contributor
|
What about changing |
Contributor
Author
OK, wait a moment. This also makes me curious why we use a wrapper macro when we can call the exact function. 😃 |
ndrs-pst
force-pushed
the
pr_shell_rename_shell_xxx_impl
branch
from
6126233 to
9cd02d6
Compare
jakub-uC
previously approved these changes
Aug 28, 2024
pdgendt
previously approved these changes
Aug 28, 2024
jukkar
previously approved these changes
Aug 28, 2024
ndrs-pst
force-pushed
the
pr_shell_rename_shell_xxx_impl
branch
from
9cd02d6 to
5927eeb
Compare
Contributor
Author
|
@jakub-uC Seem this piece of test code block the CI. |
Contributor
Author
Since the `_impl` naming convention is intended for internal use only, renaming these functions to the `shell_fprintf_xxx` variant is more suitable for calls outside the module: - `shell_info_impl` to `shell_fprintf_info` - `shell_print_impl` to `shell_fprintf_normal` - `shell_warn_impl` to `shell_fprintf_warn` - `shell_error_impl` to `shell_fprintf_error` Signed-off-by: Pisit Sawangvonganan <[email protected]>
ndrs-pst
force-pushed
the
pr_shell_rename_shell_xxx_impl
branch
from
5927eeb to
8203656
Compare
jukkar
approved these changes
Sep 9, 2024
pdgendt
approved these changes
Sep 9, 2024
henrikbrixandersen
approved these changes
Sep 9, 2024
jakub-uC
approved these changes
Sep 9, 2024
ndrs-pst
added a commit
to DDC-NDRS/zephyr_rtos
that referenced
this pull request
Sep 10, 2024
…intf` Due to the introduction of `shell_xxx_impl` wrapper functions in PR zephyrproject-rtos#75340 and rename to `shell_fprintf_xxx` in PR zephyrproject-rtos#77192 we can minimize caller overhead by eliminating direct `color` parameter passing. Signed-off-by: Pisit Sawangvonganan <[email protected]>
carlescufi
pushed a commit
that referenced
this pull request
Sep 10, 2024
…intf` Due to the introduction of `shell_xxx_impl` wrapper functions in PR #75340 and rename to `shell_fprintf_xxx` in PR #77192 we can minimize caller overhead by eliminating direct `color` parameter passing. Signed-off-by: Pisit Sawangvonganan <[email protected]>
ndrs-pst
added a commit
to DDC-NDRS/zephyr_rtos
that referenced
this pull request
Sep 13, 2024
…intf` Due to the introduction of `shell_fprintf_normal` in PR zephyrproject-rtos#77192, we can minimize caller overhead by eliminating direct `color` parameter passing. Signed-off-by: Pisit Sawangvonganan <[email protected]>
nashif
pushed a commit
that referenced
this pull request
Sep 17, 2024
…intf` Due to the introduction of `shell_fprintf_normal` in PR #77192, we can minimize caller overhead by eliminating direct `color` parameter passing. Signed-off-by: Pisit Sawangvonganan <[email protected]>
ndrs-pst
added a commit
to DDC-NDRS/zephyr_rtos
that referenced
this pull request
Jan 22, 2025
…intf` Due to the introduction of `shell_fprintf_normal` in PR zephyrproject-rtos#77192, we can minimize caller overhead by eliminating direct `color` parameter passing. Signed-off-by: Pisit Sawangvonganan <[email protected]>
kartben
pushed a commit
that referenced
this pull request
Mar 24, 2025
…intf` Due to the introduction of `shell_fprintf_normal` in PR #77192, we can minimize caller overhead by eliminating direct `color` parameter passing. Signed-off-by: Pisit Sawangvonganan <[email protected]>
jeppenodgaard
pushed a commit
to jeppenodgaard/zephyr
that referenced
this pull request
Mar 25, 2025
…intf` Due to the introduction of `shell_fprintf_normal` in PR zephyrproject-rtos#77192, we can minimize caller overhead by eliminating direct `color` parameter passing. Signed-off-by: Pisit Sawangvonganan <[email protected]>
KwsBaer
pushed a commit
to kwsgmbh/zephyr
that referenced
this pull request
Apr 3, 2025
…intf` Due to the introduction of `shell_fprintf_normal` in PR zephyrproject-rtos#77192, we can minimize caller overhead by eliminating direct `color` parameter passing. Signed-off-by: Pisit Sawangvonganan <[email protected]>
csarip
pushed a commit
to csarip/zephyr
that referenced
this pull request
Jun 2, 2025
…intf` Due to the introduction of `shell_fprintf_normal` in PR zephyrproject-rtos#77192, we can minimize caller overhead by eliminating direct `color` parameter passing. Signed-off-by: Pisit Sawangvonganan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
_implnaming convention is intended for internal use only, renaming these functions to theshell_fprintf_xxxvariant is more suitable for calls outside the module:shell_info_impltoshell_fprintf_infoshell_print_impltoshell_fprintf_normalshell_warn_impltoshell_fprintf_warnshell_error_impltoshell_fprintf_errorThis change is related to PR #77165.